Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update relation map in relations.py to match expectations #696

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

sierra-moxon
Copy link
Member

Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refresh and tests added--looks good to me

@kltm
Copy link
Member

kltm commented Oct 9, 2024

@dustine32 One your approval, could you setup a ontobio release and bump the pipeline?

@sierra-moxon
Copy link
Member Author

sierra-moxon commented Nov 11, 2024

@dustine32 - does this look ok? If we can hold off for another 24 hrs on making a release, I can get the new GPAD header stuff in. :) But it would be good to merge this into the main branch so I can pick it up in my next PR.

Copy link
Collaborator

@dustine32 dustine32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sierra-moxon Yep, this is a straightforward change and thank you for the thorough tests!

@sierra-moxon sierra-moxon merged commit 4d591cd into master Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants