Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] test_owcsvimport: Workaround for segfault in tests on macos #6735

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Feb 16, 2024

Issue

test_owcsvimport tests sometimes segfault in CI tests.

test_browse (Orange.widgets.data.tests.test_owcsvimport.TestOWCSVFileImport) ... ok
test_browse_for_missing (Orange.widgets.data.tests.test_owcsvimport.TestOWCSVFileImport) ... Fatal Python error: Segmentation fault

Thread 0x000070000d724000 (most recent call first):
  File "/Users/runner/work/orange3-installers/orange3-installers/mnt/Orange3.app/Contents/Frameworks/Python.framework/Versions/3.10/lib/python3.10/concurrent/futures/thread.py", line 81 in _worker
  File "/Users/runner/work/orange3-installers/orange3-installers/mnt/Orange3.app/Contents/Frameworks/Python.framework/Versions/3.10/lib/python3.10/threading.py", line 953 in run
  File "/Users/runner/work/orange3-installers/orange3-installers/mnt/Orange3.app/Contents/Frameworks/Python.framework/Versions/3.10/lib/python3.10/threading.py", line 1016 in _bootstrap_inner
  File "/Users/runner/work/orange3-installers/orange3-installers/mnt/Orange3.app/Contents/Frameworks/Python.framework/Versions/3.10/lib/python3.10/threading.py", line 973 in _bootstrap

Specifically this almost always happens in the installer tests.

When build against this branch the installer tests seem to pass

Description of changes

Explicitly schedule the deletion of QFileDialog before the parent widget.

Includes
  • Code changes
  • Tests
  • Documentation

Explicitly schedule the deletion of QFileDialog before the parent
widget.
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Merging #6735 (febf466) into master (53710be) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6735      +/-   ##
==========================================
- Coverage   88.14%   88.13%   -0.01%     
==========================================
  Files         322      322              
  Lines       70589    70589              
==========================================
- Hits        62220    62216       -4     
- Misses       8369     8373       +4     

@ales-erjavec ales-erjavec changed the title test_owcsvimport: Possible workaround for segfault in tests on macos [FIX] test_owcsvimport: Workaround for segfault in tests on macos Feb 23, 2024
@PrimozGodec PrimozGodec merged commit ba951fa into biolab:master Feb 29, 2024
19 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants