[FIX] PCA - Output instance of table subclass when instance of table subclass on input #6536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6536 +/- ##
=======================================
Coverage 87.68% 87.68%
=======================================
Files 321 321
Lines 69403 69406 +3
=======================================
+ Hits 60857 60860 +3
Misses 8546 8546 |
markotoplak
reviewed
Aug 17, 2023
| @@ -355,10 +355,9 @@ def commit(self): | |||
| self.data.domain.attributes, | |||
| self.data.domain.class_vars, | |||
| self.data.domain.metas + domain.attributes) | |||
| data = Table.from_numpy( | |||
| data_dom, self.data.X, self.data.Y, | |||
| numpy.hstack((self.data.metas, transformed.X)), | |||
There was a problem hiding this comment.
How about replacing everything about this output with the code below? Sure, then, these are transformed twice, but I think this transformation is fast enough so that we do not need to worry.
data = self.data.transform(add_columns(self.data.domain,
metas=domain.attributes))
This is what @noahnovsak did on the dask brach.
There was a problem hiding this comment.
Forgot about this option. It is done now.
There was a problem hiding this comment.
Now you do not need the next part (under with:)
PrimozGodec
force-pushed
the
fix-pca
branch
2 times, most recently
from
137367a
to
75399dc
Compare
PrimozGodec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When PCA receives Corpus on input,
Transformed Dataoutputs Corpus instance whileDataoutputs Table.Description of changes
Dataoutput outputs the instance of Table subclass (e.g. Corpus) in the described situation.Includes