Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Group By - Fix error with hidden attributes #6473

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

PrimozGodec
Copy link
Contributor

Issue

Fixes (partially) #6367

Description of changes

Make Group By work with hidden attributes in the table

Additionally: Replace deprecated ListViewSearch with ListViewFilter and use it directly via gui.listView

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec marked this pull request as ready for review June 9, 2023 10:20
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #6473 (d9f5dd1) into master (a2c8956) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6473      +/-   ##
==========================================
- Coverage   87.63%   87.63%   -0.01%     
==========================================
  Files         321      321              
  Lines       69281    69270      -11     
==========================================
- Hits        60715    60704      -11     
  Misses       8566     8566              

@PrimozGodec PrimozGodec changed the title Group By - Fix error with hidden attributes [FIX] Group By - Fix error with hidden attributes Jun 9, 2023
@janezd janezd self-assigned this Jun 16, 2023
@janezd janezd merged commit 828a535 into biolab:master Jun 16, 2023
@PrimozGodec PrimozGodec deleted the groupby-hiden branch February 16, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants