[FIX] Sql - Fix comparison with values trailing spaces #6470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6470 +/- ##
=======================================
Coverage 87.63% 87.63%
=======================================
Files 321 321
Lines 69281 69281
=======================================
+ Hits 60715 60716 +1
+ Misses 8566 8565 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Loading table fails when values of the column in the table have trailing spaces, and the column interprets as DiscreteVariable since MSSQl ignore trailing spaces while comparing string values.
Description of changes
Add
DATALENGTHtogroupbycomparison to ensure trailing spaces are not ignored while grouping.Includes