Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] SOM - Warn user to restart optimization after parameter change #6438

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

PrimozGodec
Copy link
Contributor

Issue

Fixes #6424

Description of changes

Similarly in t-SNE, it is better that user is warned to rerun optimization after changing parameters.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec marked this pull request as ready for review April 27, 2023 07:18
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #6438 (10b7a72) into master (7c28d74) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6438   +/-   ##
=======================================
  Coverage   87.65%   87.65%           
=======================================
  Files         321      321           
  Lines       69148    69173   +25     
=======================================
+ Hits        60610    60633   +23     
- Misses       8538     8540    +2     

@janezd janezd self-assigned this Apr 28, 2023
@janezd janezd merged commit 6b47e02 into biolab:master Apr 28, 2023
@PrimozGodec PrimozGodec deleted the som-info-restart branch February 16, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Square grid in Self-Organizing Map not working
2 participants