-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] New icons and splash screen #5814
Conversation
Converted as gs -q -sDEVICE=pngalpha -o %stdout -r300 orange_rgb_icon_.pdf | \ convert -background transparent - -resize 48x48 icon-48.png gs -q -sDEVICE=pngalpha -o %stdout -r300 orange_rgb_icon_.pdf | \ convert -background transparent - -resize 256x256 icon-256.png
Converted with: gs -q -sDEVICE=pngalpha -o %stdout -r300 orange_rgb_icon_.pdf | \ convert -background transparent - -define icon:auto-resize=16,32,48,64,256 orange.ico
Codecov Report
@@ Coverage Diff @@
## master #5814 +/- ##
==========================================
- Coverage 86.14% 86.13% -0.01%
==========================================
Files 316 316
Lines 66388 66419 +31
==========================================
+ Hits 57187 57213 +26
- Misses 9201 9206 +5 |
I am so happy this is finally moving in the right direction. I have some comments, though.
Otherwise, the images are in the right place, so all good. But definitely have to test it with an installer. |
Which images? There are:
I'd leave it out of these. I do not think we agreed on anything there, for now. |
Splash screens. Probably because they are non-retina. |
@ajdapretnar, I do not have retinized splash screens ready, so I think that would be best handled in a different PR. Also the colors. This PR would be best tested with builds from its companion installer PR: ales-erjavec/orange3-installers#23 I only tested the Mac installers. |
I can confirm the .dmg installer works nicely for me. |
Works fine on Windows as well. |
From material from biolab/orange-graphics@6e4cdf5
Apart from this some things will have to also be replaced in the installer repository. There are some icons there and the DMG screens.I tried to cover everything in this repo, but very likely I missed something...
Before merging this test installers should be built.See installers in ales-erjavec/orange3-installers#23