Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] New icons and splash screen #5814

Merged
merged 5 commits into from
Feb 7, 2022
Merged

Conversation

markotoplak
Copy link
Member

@markotoplak markotoplak commented Jan 28, 2022

From material from biolab/orange-graphics@6e4cdf5

Apart from this some things will have to also be replaced in the installer repository. There are some icons there and the DMG screens.

I tried to cover everything in this repo, but very likely I missed something...

Before merging this test installers should be built.

See installers in ales-erjavec/orange3-installers#23

Converted as

gs -q -sDEVICE=pngalpha -o %stdout -r300 orange_rgb_icon_.pdf | \
  convert -background transparent - -resize 48x48 icon-48.png

gs -q -sDEVICE=pngalpha -o %stdout -r300 orange_rgb_icon_.pdf | \
  convert -background transparent - -resize 256x256 icon-256.png
Converted with:

gs -q -sDEVICE=pngalpha -o %stdout -r300 orange_rgb_icon_.pdf | \
  convert -background transparent - -define icon:auto-resize=16,32,48,64,256 orange.ico
@markotoplak markotoplak marked this pull request as draft January 28, 2022 20:16
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #5814 (d123b6f) into master (dfd2734) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5814      +/-   ##
==========================================
- Coverage   86.14%   86.13%   -0.01%     
==========================================
  Files         316      316              
  Lines       66388    66419      +31     
==========================================
+ Hits        57187    57213      +26     
- Misses       9201     9206       +5     

@ajdapretnar
Copy link
Contributor

I am so happy this is finally moving in the right direction.

I have some comments, though.

  • The resolution of the images, at least on my 4k screen, seems very grainy.
  • We should probably replace the colors of core categories, too? I think this was the idea at least.
  • Welcome screen is still as it was. Are we keeping it this way or are there any changes planned?

Otherwise, the images are in the right place, so all good. But definitely have to test it with an installer.

@markotoplak
Copy link
Member Author

* The resolution of the images, at least on my 4k screen, seems very grainy.

Which images? There are:

  • It was just the icons, which are the same size and before (the largest being 256x256).
  • And the splash screens, which are currently non-retina renders.
* Welcome screen is still as it was. Are we keeping it this way or are there any changes planned?

I'd leave it out of these. I do not think we agreed on anything there, for now.

@ajdapretnar
Copy link
Contributor

Splash screens. Probably because they are non-retina.

@markotoplak
Copy link
Member Author

@ajdapretnar, I do not have retinized splash screens ready, so I think that would be best handled in a different PR. Also the colors.

This PR would be best tested with builds from its companion installer PR: ales-erjavec/orange3-installers#23

I only tested the Mac installers.

@markotoplak markotoplak marked this pull request as ready for review February 3, 2022 15:30
@ajdapretnar
Copy link
Contributor

I can confirm the .dmg installer works nicely for me.
We should keep in mind we are still "testing" #5712. So before the official release we should agree that we like the changes.

@thocevar
Copy link
Contributor

thocevar commented Feb 4, 2022

Works fine on Windows as well.

@JakaKokosar
Copy link
Member

Works fine on macOS Monterey (v12.1)

A minor thing about DMG folder style:

when I open the installer,
Screenshot 2022-02-06 at 13 37 09

expected (make window size match the background image)
Screenshot 2022-02-06 at 13 37 22

@markotoplak markotoplak merged commit c38b96f into biolab:master Feb 7, 2022
@markotoplak markotoplak deleted the new-cgp branch February 28, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants