Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ExcelReader: Write roles #5810

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Jan 27, 2022

Issue

Fixes #5798

Description of changes

Beside headers, also save types and flags.

Includes
  • Code changes
  • Tests
  • Documentation

@markotoplak
Copy link
Member

From the code it seems that headers are always written, but this should, instead, respect users' setting in the widget.

Furthermore, for backward compatibility, the add type annotations could get disabled when opening saved workflows that save to Excel.

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #5810 (ee88eeb) into master (dfd2734) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5810      +/-   ##
==========================================
- Coverage   86.14%   86.13%   -0.01%     
==========================================
  Files         316      316              
  Lines       66388    66398      +10     
==========================================
+ Hits        57187    57191       +4     
- Misses       9201     9207       +6     

@VesnaT
Copy link
Contributor Author

VesnaT commented Jan 27, 2022

From the code it seems that headers are always written, but this should, instead, respect users' setting in the widget.

I wasn't even aware we have that. I'll fit it.

Furthermore, for backward compatibility, the add type annotations could get disabled when opening saved workflows that save to Excel.

I'm not sure I want to support backward compatibility for something that didn't work correctly.

@markotoplak
Copy link
Member

Furthermore, for backward compatibility, the add type annotations could get disabled when opening saved workflows that save to Excel.

I'm not sure I want to support backward compatibility for something that didn't work correctly.

My perspective on this is that for some users, especially for those that saved those workflows, the output was exactly what they needed or they somehow adapted to. Perhaps they just accepted that type setting as something that does not apply to Excel files. If they loaded their workflows after the changes, the saved files are going to change, which can lead to problems later on.

The number of users relying on this is likely small and perhaps we can ignore them and just break things for them... But on the other hand, supporting that here is easy: we could just add the rule on setting open if setting_version_old and use_excel: value_setting = False. So no special support of old behaviors, just setting change.

Orange/data/io.py Outdated Show resolved Hide resolved
@janezd janezd self-assigned this Jan 28, 2022
@janezd janezd merged commit bd737a6 into biolab:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excel Writer does not save roles
3 participants