[FIX] Unpickling pre-3.28.0 Transformation #5759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5759 +/- ##
==========================================
- Coverage 86.15% 86.15% -0.01%
==========================================
Files 315 315
Lines 66186 66195 +9
==========================================
+ Hits 57023 57030 +7
- Misses 9163 9165 +2 |
markotoplak
changed the title
At around 3.28 we introduced domain caching into Tranformation in a way that prevented older pickles to work. This fix recreates the cache after unpickling. Furthermore, the cache (before "need_domain", now "_target_domain") is never pickled anymore.
markotoplak
force-pushed
the
fix-transformation-upickling
branch
from
1bf6300
to
246d534
Compare
markotoplak
pushed a commit
to markotoplak/orange3
that referenced
this pull request
Jan 7, 2022
…ickling [FIX] Unpickling pre-3.28.0 Transformation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
At around 3.28 we introduced domain caching into
Transformationin a way that prevented older pickles to work. Fixes #5758.Description of changes
This fix recreates the cache after unpickling. Furthermore, the cache (before
need_domain, now_target_domain) is never pickled anymore.Includes