[FIX] Fix running OWS with widgets with WebView in Orange.canvas.run #5657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #5657 +/- ##
==========================================
+ Coverage 85.97% 86.05% +0.07%
==========================================
Files 313 315 +2
Lines 65649 65954 +305
==========================================
+ Hits 56444 56758 +314
+ Misses 9205 9196 -9 |
|
@PetrDlouhy Can you sign the CLA? |
PetrDlouhy
force-pushed
the
fix_webview
branch
from
a8b86ae
to
f58a311
Compare
|
@ales-erjavec I signed now. I also corrected part of the pylint errors, but I can't get rid of the |
PetrDlouhy
force-pushed
the
fix_webview
branch
from
f58a311
to
c3a8418
Compare
|
I solved the linting problem. I expect the failing tests are caused by failing master. |
ales-erjavec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fix of running OWS with widgets with WebView in Orange.canvas.run (more details here: biolab/orange-canvas-core#209)
Description of changes
Importing WebviewWidget soon is enough to make the WebView work.
Includes