[FIX] Prevent crash when saving in unsupported format #5560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5560 +/- ##
=======================================
Coverage 85.91% 85.92%
=======================================
Files 313 313
Lines 65349 65365 +16
=======================================
+ Hits 56143 56163 +20
+ Misses 9206 9202 -4 |
janezd
force-pushed
the
save-unsupported-format
branch
from
8301653
to
ff6f50c
Compare
1 task
|
Check widgets for reading. |
|
I checked: the File widget does not crash and even has a test for it. Load Model and Distance File have only a single extension and no registry. Unlike the widgets for saving, widgets for reading do not have a common base, so there's nothing to fix. This can be reviewed as is. Volunteers welcome. |
VesnaT
reviewed
Sep 6, 2021
| @@ -43,6 +43,7 @@ class Information(widget.OWWidget.Information): | |||
|
|
|||
| class Error(widget.OWWidget.Error): | |||
| no_file_name = widget.Msg("File name is not set.") | |||
| unsupported_format = widget.Msg("File fornat is unsupported.\n{}") | |||
janezd
force-pushed
the
save-unsupported-format
branch
from
ff6f50c
to
e2ecd97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #5512.
The situtation can occur if workflow is saved with Orange that has add-ons with additional file formats and then opened in Orange without that add-on, or if support for some format is dropped (as was the case with old Excel, which caused #5512).
Description of changes
Save widget base
Widgets for saving are derived from
OWSaveBase, which fails in propertywriter. This PR changes it to returnNonefor filters that are not in the list. The only place wherewriteris used isdo_save, which in this case now indicates an error.The error is cleared at the only place that changes
self.filter: if the user selects a new file name, the filter cannot be invalid.Derived widgets
Derived widgets need changes only if they use
self.writer, in which case they must check that it is notNone. Among the three core widgets, onlySavedoes, and this PR adapts it accordingly.Save ModelandSave Distancesshouldn't need any changes.The consequence of not checking for
self.writer is Noneis a crash -- like previously, just a bit later (when using the property instead of when obtaining it).Includes