[FIX] Fix deepcopy and pickle for classes derived from np.ndarray
#5536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5536 +/- ##
==========================================
- Coverage 86.38% 86.38% -0.01%
==========================================
Files 304 304
Lines 61753 61773 +20
==========================================
+ Hits 53344 53360 +16
- Misses 8409 8413 +4 |
janezd
force-pushed
the
distribution-deepcopy
branch
from
cc87090
to
edc12b3
Compare
janezd
force-pushed
the
distribution-deepcopy
branch
from
edc12b3
to
41413ad
Compare
janezd
changed the title
np.ndarraynp.ndarray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #5480.
Description of changes
Apparently and hopefully, the only classes derived from
np.ndarrayaredistribution.Discrete,distribution.Continuous,contingency.DiscreteandDistMatrix. The latter was already properly subclassed, so I did the same in the first three.DistMatrixalso implements__array_wrap__; I haven't added it to the former three classes because it would change their behaviour and possible break some code without (much, if any) benefit.Includes