[FIX] owpca: fix component selection when dragging selection line #5469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5469 +/- ##
==========================================
- Coverage 86.36% 86.35% -0.01%
==========================================
Files 304 304
Lines 61652 61652
==========================================
- Hits 53244 53240 -4
- Misses 8408 8412 +4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #5464
Description of changes
Check for
self._pca is not None and components == len(self._variance_ratio)prevented self.ncomponents to get updated when dragging vertical line.I think this check is unnecessary since the vertical line is bounded (on the x-axis) and will never exceed the number of computed components.
Includes