Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix line plot's send_report #5018

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Oct 8, 2020

Issue

Send line plot's send report fails with pyqtgraph==0.10.0.

Traceback (most recent call last):
  File "/Users/primoz/miniconda3/envs/orange3/lib/python3.8/site-packages/pyqtgraph/graphicsItems/PlotCurveItem.py", line 183, in boundingRect
    px, py = self.pixelVectors()
  File "/Users/primoz/miniconda3/envs/orange3/lib/python3.8/site-packages/pyqtgraph/graphicsItems/GraphicsItem.py", line 251, in pixelVectors
    dti = fn.invertQTransform(dt)
  File "/Users/primoz/miniconda3/envs/orange3/lib/python3.8/site-packages/pyqtgraph/functions.py", line 2199, in invertQTransform
    inv = numpy.linalg.inv(arr)
  File "<__array_function__ internals>", line 5, in inv
  File "/Users/primoz/miniconda3/envs/orange3/lib/python3.8/site-packages/numpy/linalg/linalg.py", line 546, in inv
    ainv = _umath_linalg.inv(a, signature=signature, extobj=extobj)
  File "/Users/primoz/miniconda3/envs/orange3/lib/python3.8/site-packages/numpy/linalg/linalg.py", line 88, in _raise_linalgerror_singular
    raise LinAlgError("Singular matrix")
numpy.linalg.LinAlgError: Singular matrix

The error was discovered while testing orange3-installers https://github.com/ales-erjavec/orange3-installers/runs/1224911463

Description of changes

The bug was fixed in pyqtgraph==0.11.0 so increasing the minimum version of pyqtgraph.
pyqtgraph fix: pyqtgraph/pyqtgraph#1173

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #5018 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5018      +/-   ##
==========================================
+ Coverage   84.61%   84.65%   +0.04%     
==========================================
  Files         285      285              
  Lines       59508    59508              
==========================================
+ Hits        50353    50378      +25     
+ Misses       9155     9130      -25     

@PrimozGodec PrimozGodec merged commit 5ece097 into biolab:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant