Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ownomogram: Fix wrapped C++ obj error #5005

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

irgolic
Copy link
Member

@irgolic irgolic commented Sep 25, 2020

Issue

#4998 was throwing this

Traceback (most recent call last):
  File "/home/runner/work/orange3/orange3/.tox/coverage/lib/python3.7/site-packages/Orange/widgets/visualize/ownomogram.py", line 266, in brushColor
    item.setBrush(value)
RuntimeError: wrapped C/C++ object of type DiscreteMovableDotItem has been deleted

This PR fixes it.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #5005 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5005   +/-   ##
=======================================
  Coverage   84.65%   84.65%           
=======================================
  Files         284      284           
  Lines       58935    58943    +8     
=======================================
+ Hits        49891    49900    +9     
+ Misses       9044     9043    -1     

@janezd janezd merged commit 1a2ae34 into biolab:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants