[FIX] Fix slicing in from_table #4963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4963 +/- ##
==========================================
- Coverage 84.29% 84.29% -0.01%
==========================================
Files 283 283
Lines 58016 58013 -3
==========================================
- Hits 48904 48900 -4
- Misses 9112 9113 +1 |
Slicing in from_table was not properly tested, because the same domain was used and therefore the calls for forwarded to from_table_rows.
Handcraft (but wrong) measuring of slice length was replaced with calling standard methods.
markotoplak
force-pushed
the
fix-from-table-slicing
branch
from
7064b75
to
9bcc22a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
For reverse slices row_indices in Table.from_table did not work properly. Also, that part of
from_tablewas not properly tested, probably because of some optimizations that were added later.Description of changes
Handcrafted (but wrong) measuring of slice length was replaced with calling standard methods.
Includes