Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Line Plot: Reset axis ticks on data change #4873

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Jul 2, 2020

Issue

In some cases tick texts retain after changing data on widget's input.
To reproduce:

  • File(Iris) -> Select columns (Click Reset just in case) -> Line Plot (Check Mean)
  • In Select column move all features to Available variables -> Ticks on Line plot retain
Description of changes

Remove tick texts on data change.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #4873 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4873      +/-   ##
==========================================
- Coverage   84.17%   84.14%   -0.03%     
==========================================
  Files         282      277       -5     
  Lines       57464    56638     -826     
==========================================
- Hits        48368    47658     -710     
+ Misses       9096     8980     -116     

@janezd janezd merged commit 5632982 into biolab:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants