[ENH] get_unique_names: Handle more independent names #4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
ge-unique-nonequal-numbers
branch
from
25de34e
to
cebb02f
Compare
PrimozGodec
force-pushed
the
ge-unique-nonequal-numbers
branch
from
cebb02f
to
dc24036
Compare
Codecov Report
@@ Coverage Diff @@
## master #4866 +/- ##
==========================================
- Coverage 84.20% 84.18% -0.03%
==========================================
Files 282 277 -5
Lines 57331 56506 -825
==========================================
- Hits 48276 47567 -709
+ Misses 9055 8939 -116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
get_unique_names always returns names with all the same indices e.g. If we have an existing names: ['foo', 'baz', 'baz (1)'] and we want to add ['foo', 'baz'], new names will be ['foo (2)', 'baz (2)'].
Description of changes
With this PR we are adding the possibility handle names which are independent. If the user sets
equal_numbers=False. She/he will now get ['foo (1)', 'baz (2)'].Includes