Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Select Columns: Fix attributes sorting #4827

Merged
merged 1 commit into from
May 28, 2020

Conversation

PrimozGodec
Copy link
Contributor

Issue

Select Columns widget fails when getting data with additional attributes.

Description of changes

Fixed sorting of attributes that it does not compare Variables while sorting.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title Select column: Fix attributes sorting Select columns: Fix attributes sorting May 28, 2020
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #4827 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4827      +/-   ##
==========================================
- Coverage   84.01%   83.99%   -0.02%     
==========================================
  Files         281      276       -5     
  Lines       56897    56070     -827     
==========================================
- Hits        47802    47098     -704     
+ Misses       9095     8972     -123     

@lanzagar lanzagar changed the title Select columns: Fix attributes sorting [FIX] Select Columns: Fix attributes sorting May 28, 2020
@lanzagar lanzagar merged commit f1ea981 into biolab:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants