Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix report in Predictions #4709

Merged
merged 3 commits into from
May 8, 2020

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Apr 29, 2020

Issue
  • Fixes Opening report on Predictions widget crashes #4652. Report crashed since we removed info label in favour of summaries (my mistake!)
  • Report also didn't have anything in the prediction columns. This was added.
  • Report did not include the table with scores at the bottom. Added, too.
Includes
  • Code changes
  • Tests, minimalistic

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #4709 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4709      +/-   ##
==========================================
+ Coverage   83.70%   83.72%   +0.01%     
==========================================
  Files         280      275       -5     
  Lines       56450    55653     -797     
==========================================
- Hits        47253    46595     -658     
+ Misses       9197     9058     -139     

@ajdapretnar ajdapretnar self-assigned this May 7, 2020
@ajdapretnar ajdapretnar merged commit 41e015e into biolab:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening report on Predictions widget crashes
2 participants