[FIX] Pythagorantrees/forests: change context handler #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
pythagorantrees
branch
4 times, most recently
from
02241aa
to
4dccf71
Compare
|
@PrimozGodec, could you rebase this to master, so we can see the tests? |
PrimozGodec
force-pushed
the
pythagorantrees
branch
from
4dccf71
to
f3a6562
Compare
Codecov Report
@@ Coverage Diff @@
## master #4656 +/- ##
==========================================
- Coverage 83.67% 83.65% -0.03%
==========================================
Files 280 275 -5
Lines 56348 55539 -809
==========================================
- Hits 47152 46462 -690
+ Misses 9196 9077 -119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Pythagorantrees and Pythagorantrees use domain context handler without having any context variable with variables from the domain
Description of changes
DomainContextHandler replaced with ClassValuesContextHandler
Besides: Fixed warnings about setting index (for the selected item) when an empty combo box
Includes