[FIX] PyTableModel: Allow wrapping empty lists #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
added
urgent
janezd
force-pushed
the
pytablemodel-wrap-empty
branch
from
7c892ba
to
8ccdd2a
Compare
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #4631 +/- ##
==========================================
- Coverage 83.65% 83.63% -0.02%
==========================================
Files 281 276 -5
Lines 56269 55464 -805
==========================================
- Hits 47072 46388 -684
+ Misses 9197 9076 -121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
PyTableModel's constructor does not wrap an empty list but wraps another, new empty list instead.Constructor has an argument
sequencewith defaultNoneand then wrapssequence or []. This is not OK whensequenceis[].Includes