-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Outliers: Offload work onto separate thread #4412
Conversation
e019f32
to
390108f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4412 +/- ##
==========================================
- Coverage 87.46% 87.45% -0.01%
==========================================
Files 405 405
Lines 73968 74118 +150
==========================================
+ Hits 64693 64817 +124
- Misses 9275 9301 +26 |
390108f
to
32b48e8
Compare
Thank you @VesnaT, I like it a lot! |
Orange/base.py
Outdated
@@ -101,7 +102,7 @@ def fit_storage(self, data): | |||
X, Y, W = data.X, data.Y, data.W if data.has_weights() else None | |||
return self.fit(X, Y, W) | |||
|
|||
def __call__(self, data): | |||
def __call__(self, data, callback=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I glanced over this PR. The only thing I don't like is the name of the argument. callback
can be anything. Perhaps progress_callback
? Longer, but more informative.
32b48e8
to
752abbd
Compare
Issue
Responsive Outliers widget: the widget could make calculations in a separate thread to make Orange responsive.
Description of changes
progress_callback
function that serves as a wrapper function for callbacks. It allocates the corresponding proportion of the progress to the callback.Learner
to enable preprocessing interruption._OutlierModel
.Includes