[ENH] OWFeatureStatistics: data info displayed in the status bar #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4409 +/- ##
==========================================
+ Coverage 87.43% 87.45% +0.01%
==========================================
Files 405 405
Lines 74073 74081 +8
==========================================
+ Hits 64769 64784 +15
+ Misses 9304 9297 -7 |
VesnaT
requested changes
Feb 12, 2020
| @@ -792,11 +786,14 @@ def set_data(self, data): | |||
| self.data = data | |||
|
|
|||
| if data is not None: | |||
| self.info.set_input_summary(self.info.format_number(len(data)), | |||
There was a problem hiding this comment.
Consider removing format_number call:
biolab/orange-widget-base#41
| self.Outputs.reduced_data.send(None) | ||
| self.Outputs.statistics.send(None) | ||
| return | ||
|
|
||
| # Send a table with only selected columns to output | ||
| variables = self.model.variables[self.selected_rows] | ||
| self.info.set_output_summary( | ||
| self.info.format_number(len(self.data[:, variables])), \ |
There was a problem hiding this comment.
The backslash in unnecessary.
| @@ -463,6 +467,39 @@ def test_restores_previous_selection(self): | |||
| self.send_signal(self.widget.Inputs.data, self.data1) | |||
| self.assertEqual(len(self.widget.selected_rows), 2) | |||
|
|
|||
| class TestSummary(WidgetTest): | |||
There was a problem hiding this comment.
The test case is indented and therefore never executed.
aturanjanin
changed the title
aturanjanin
force-pushed
the
owfeaturestatistics
branch
from
ec54594
to
87327c2
Compare
aturanjanin
force-pushed
the
owfeaturestatistics
branch
from
87327c2
to
da254c7
Compare
aturanjanin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The drop-down list for choosing color of histograms was very narrow so feature names were not seen properly.
Description of changes
Display input and output data info in the status bar.
Made Color drop-down list wider.
Includes