Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] DataProjectionWidget: attribute Selected #4393

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

AndrejaKovacic
Copy link
Contributor

@AndrejaKovacic AndrejaKovacic commented Feb 3, 2020

Issue

Fixes #4369

Includes
  • Code changes
  • Tests

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #4393 into master will increase coverage by 0.2%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #4393     +/-   ##
=========================================
+ Coverage   86.97%   87.18%   +0.2%     
=========================================
  Files         396      401      +5     
  Lines       72143    72946    +803     
=========================================
+ Hits        62749    63600    +851     
+ Misses       9394     9346     -48

Copy link
Contributor

@janezd janezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. @VesnaT, could you take a quick look, too, just to be safe?

To my understanding, the problem is that graph.get_selection returns indices into valid_data, while group_sel is "reindexed" onto input data. But I may be wrong, so .... @VesnaT :)

@janezd janezd merged commit a011110 into biolab:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scatter plot missing value rows are selected
2 participants