[FIX] Error message on tSNE with one variable #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
reviewed
Jan 24, 2020
| self.assertTrue(self.widget.Error.not_enough_cols.is_shown()) | ||
|
|
||
| # one attributes | ||
| self.data = Table.from_list(self.empty_domain, [[1, 'STG1'], |
There was a problem hiding this comment.
@rokgomiscek, pylint complains about self.data being defined outside constructor. This doesn't happen just in your code but throughout this function. Could you change this to a local variable in all places? I assume this doesn't need to be an attribute.
There was a problem hiding this comment.
@janezd, changed
rokgomiscek
force-pushed
the
tSNE_one_variable
branch
from
7974c3c
to
34e5b86
Compare
Codecov Report
@@ Coverage Diff @@
## master #4364 +/- ##
==========================================
+ Coverage 86.97% 86.98% +<.01%
==========================================
Files 396 396
Lines 72144 72152 +8
==========================================
+ Hits 62750 62758 +8
Misses 9394 9394 |
rokgomiscek
force-pushed
the
tSNE_one_variable
branch
from
34e5b86
to
e52b104
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4354
Description of changes
Changed trigger for Error to number of attributes.
Includes