Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] OWTreeViewer: Bold predicted values in tree nodes #4269

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

irgolic
Copy link
Member

@irgolic irgolic commented Dec 15, 2019

Description of changes

I think this better visually differentiates a node's prediction from its next branching feature.

Screenshot 2019-12-15 at 23 15 37

Screenshot 2019-12-15 at 23 21 31

On a tangent, is the background color of a regression tree's nodes always this color by default? Either the background's or the separator line's color should be changed.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Dec 15, 2019

Codecov Report

Merging #4269 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #4269      +/-   ##
==========================================
- Coverage   86.24%   86.24%   -0.01%     
==========================================
  Files         396      396              
  Lines       70714    70714              
==========================================
- Hits        60989    60987       -2     
- Misses       9725     9727       +2

@ajdapretnar
Copy link
Contributor

You mean is the background always purple? Yes and no. You can set the node color in the Tree Viewer. By default it is colored by, unremarkably, default color, but you can change it to mean value and such. Perhaps the default is not the best... well, default.

@irgolic
Copy link
Member Author

irgolic commented Dec 18, 2019

@ajdapretnar I'll look into changing the default color, or maybe I'll make the horizontal line white.

On another note, in the regression tree, should we bold the errors if they're significant?

@ajdapretnar
Copy link
Contributor

On another note, in the regression tree, should we bold the errors if they're significant?

I like the idea, but would they stand out enough considering the mean value is already bold?

@irgolic
Copy link
Member Author

irgolic commented Dec 18, 2019

Screenshot 2019-12-18 at 13 34 54

Also, can anyone explain why this PR is failing codecov?

@irgolic irgolic changed the title OWTreeViewer: Bold predicted values in tree nodes [ENH] OWTreeViewer: Bold predicted values in tree nodes Dec 18, 2019
@janezd janezd self-assigned this Dec 19, 2019
@janezd
Copy link
Contributor

janezd commented Dec 20, 2019

Also, can anyone explain why this PR is failing codecov?

The second of the two lines you've changed is not covered by tests, apparently. The coverage is not worse, but the diff coverage is < 95%.

Colors are indeed ugly.

As for marking significant differences, I don't like it because (a) it doesn't stand out and thus looks more like an inconsistency, (b) the user won't know why are they bold anyway, (c) significances could only be computed on separate data set, otherwise this is pure overfitting. Especially (c) is a problem.

@janezd janezd merged commit f0851e4 into biolab:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants