-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] DBSCAN widget #3917
[ENH] DBSCAN widget #3917
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3917 +/- ##
=========================================
Coverage ? 84.76%
=========================================
Files ? 373
Lines ? 65063
Branches ? 0
=========================================
Hits ? 55148
Misses ? 9915
Partials ? 0 |
Codecov Report
@@ Coverage Diff @@
## master #3917 +/- ##
==========================================
+ Coverage 85.13% 85.21% +0.08%
==========================================
Files 378 382 +4
Lines 67201 67590 +389
==========================================
+ Hits 57214 57600 +386
- Misses 9987 9990 +3 |
5f68a17
to
baf3024
Compare
6d322ce
to
58844fe
Compare
I think the widget is ready to merge. @BlazZupan do you have any comment regarding the widget design. |
Works as expected on the painted data, but then may have some problems with other kinds of data sets:
|
@BlazZupan it is fixed now |
Fails on sparse. Perhaps a quick fix with an error message to prevent it from crashing? |
@ajda it also works on bag-of-words data now. |
Description of changes
In discussion with @ajdapretnar we decided to move DBSCAN widget to core Orange. With this PR we move fixed DBSCAN widget to Orange.
Besides moving the DBSCAN widget this PR also introduce a graph that allows selection. That component is now called from OWPCA and OWDBCAN.
Note: When testing makes sure to test PCA widget too.
Includes