Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWWidget: Fix an error on mouse press when widget has no basic layout #3821

Merged

Conversation

ales-erjavec
Copy link
Contributor

Issue

If a widget has no basic layout (want_basic_layout = False) and error is raised on a mouse press
in an empty widget area.

-------------------------- AttributeError Exception ---------------------------
Traceback (most recent call last):
  File "/Users/aleserjavec/workspace/orange3/Orange/widgets/widget.py", line 830, in mousePressEvent
    self.message_bar.flashIcon()
AttributeError: 'NoneType' object has no attribute 'flashIcon'
-------------------------------------------------------------------------------
Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #3821 into master will increase coverage by <.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #3821      +/-   ##
==========================================
+ Coverage   85.06%   85.07%   +<.01%     
==========================================
  Files         374      374              
  Lines       69148    69150       +2     
==========================================
+ Hits        58820    58827       +7     
+ Misses      10328    10323       -5

@markotoplak markotoplak merged commit a733b89 into biolab:master May 28, 2019
@ales-erjavec ales-erjavec deleted the fixes/mouse-press-no-basic-layout branch March 16, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants