-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] t-SNE speed-ups #3592
[FIX] t-SNE speed-ups #3592
Conversation
@@ -258,6 +265,9 @@ def pca_preprocessing(self): | |||
def __start(self): | |||
self.pca_preprocessing() | |||
|
|||
# Dirty flag indicating whether the embedding has been drawn at least once | |||
self.needs_to_draw = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably be removed now. In any case the comment is no longer true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cannot be removed because, at the start of the optimization, we have to draw something, so we just draw some random points, because the graph widget needs some data to be shown. However, we'd like to replace this random data with something slightly more meaningful as soon as possible, so setting this to True
here will ensure that after the first batch of iterations is done, the widget will display something better than random data.
bac2463
to
914588c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3592 +/- ##
==========================================
+ Coverage 83.98% 83.98% +<.01%
==========================================
Files 370 370
Lines 66976 66984 +8
==========================================
+ Hits 56249 56256 +7
- Misses 10727 10728 +1 |
[FIX] t-SNE speed-ups
[FIX] t-SNE speed-ups
Issue
t-SNE was slow
Description of changes
transform
was being called. Avoid this.Includes