[FIX] OWDistances: Use only binary features for Jaccard distance #3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
jaccard-nonbinary
branch
from
391e5bf
to
c11b480
Compare
Codecov Report
@@ Coverage Diff @@
## master #3569 +/- ##
==========================================
- Coverage 83.97% 83.97% -0.01%
==========================================
Files 370 370
Lines 66941 66981 +40
==========================================
+ Hits 56215 56248 +33
- Misses 10726 10733 +7 |
Codecov Report
@@ Coverage Diff @@
## master #3569 +/- ##
=========================================
+ Coverage 84% 84% +<.01%
=========================================
Files 370 370
Lines 67157 67204 +47
=========================================
+ Hits 56414 56458 +44
- Misses 10743 10746 +3 |
janezd
changed the title
janezd
added
needs discussion
janezd
force-pushed
the
jaccard-nonbinary
branch
from
c11b480
to
894aa1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3559.
Description of changes
Other distances are similar and their errors, warnings and selection of attributes is handled through flags. Jaccard is specific, so I have not introduced more new flags to distances (because this flag would be used only for Jaccard, at least for now) but instead added a Jaccard-specific check to the widget.
Includes