[FIX] Don't add miniconda to path and register as system python #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... when running in silent mode.
Codecov Report
@@ Coverage Diff @@
## master #3525 +/- ##
==========================================
+ Coverage 83.58% 83.58% +<.01%
==========================================
Files 368 368
Lines 65812 65812
==========================================
+ Hits 55010 55011 +1
+ Misses 10802 10801 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When running the miniconda installer in silent mode, it might modify %PATH%, ...
Ref gh-3524
Description of changes
Add
/AddToPath=0 /RegisterPython=0to miniconda installer call when running in silent mode.Includes