-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Remove discrete attributes from scatter plot's axes #3434
Conversation
5cbc1f7
to
02fca55
Compare
Codecov Report
@@ Coverage Diff @@
## master #3434 +/- ##
==========================================
- Coverage 83.27% 83.24% -0.04%
==========================================
Files 365 365
Lines 64305 64276 -29
==========================================
- Hits 53549 53505 -44
- Misses 10756 10771 +15 |
02fca55
to
1cefe13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until this PR the widget expected self.effective_variables are always set when self.data is not None.
With this change, if there are not continuous variables in input data, self.effective_variables happens to be [None, None], which causes several errors.
Maybe you could add a check in check_data() (clearing the plot and showing an error message would be nice as well).
if self.data is not None:
if not self.data.domain.has_continuous_attributes(True, True):
self.Error.no_continuous_vars()
self.data = None
I don't mind any other solution, just make sure (a potential test - that should probably be added) passes:
def test_change_data(self):
self.send_signal(self.widget.Inputs.data, self.data)
self.send_signal(self.widget.Inputs.data, Table("titanic"))
05c3811
to
80ef6bd
Compare
Thanks for the fix and the test (I also added a few checks). |
80ef6bd
to
a32bed9
Compare
a32bed9
to
eaf793c
Compare
Issue
Fixes #3318.
Includes