Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Use minimal keyring implementation for tests #3359

Merged
merged 2 commits into from
Nov 6, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

The test is dependent on system configuration

Description of changes

Use a minimal in-memory keyring implementation for the test.
Also update the numpy version in the requirements.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #3359 into master will increase coverage by <.01%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##           master    #3359      +/-   ##
==========================================
+ Coverage   82.21%   82.21%   +<.01%     
==========================================
  Files         351      351              
  Lines       62301    62320      +19     
==========================================
+ Hits        51219    51236      +17     
- Misses      11082    11084       +2

@lanzagar lanzagar merged commit 23e622a into biolab:master Nov 6, 2018
@lanzagar lanzagar added this to the 3.18 milestone Nov 7, 2018
@ales-erjavec ales-erjavec deleted the fixes/credentials-test branch May 20, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants