[FIX] Scatterplot's VizRank no longer crashes in presence of nonprimitive metas #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
fix-vizrank-meta
branch
from
ac4f570
to
f4f6d7a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3347 +/- ##
==========================================
+ Coverage 82.21% 82.21% +<.01%
==========================================
Files 351 351
Lines 62301 62326 +25
==========================================
+ Hits 51219 51241 +22
- Misses 11082 11085 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
VizRank crashes when the data includes non-primitive meta attributes. Most notably, it crashes on Brown data!
When reimplementing projections, we removed the obsolete
graph.scaled_data. Vizrank, which used to get the attributes fromgraph.scaled_data.domain, now takes them from widget'sdata.domain, but does not filter out primitive attributes (which it didn't have to do before, sincescaled_datadid not include them).Description of changes
Add the check and the tests.
Includes