Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Install widget help files #3345

Merged
merged 2 commits into from
Nov 9, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

The widget html help files should be available offline on installation.

Fixes gh-2019

Description of changes

Install widget help files by default. This can be overridden by a --without-htmlhelp cmd line flag.

Includes
  • Code changes
  • Tests
  • Documentation

* Selectively disable numpy.distutils install_data command
* Add --with[out]-htmlhelp options for `sdist` and `build` commands
  (by default the documentation is build if sphinx is installed)
@lanzagar lanzagar added this to the 3.18 milestone Nov 7, 2018
@lanzagar lanzagar merged commit 68adc89 into biolab:master Nov 9, 2018
@lanzagar
Copy link
Contributor

lanzagar commented Nov 9, 2018

After merging this the BUILD_DOCS test on travis started failing.
I see it was my fault for being to eager to merge - not really sure why I didn't rerun the tests, but it probably looked like just the old tests were failing which were later removed. It turns out there is an actual problem with building the docs that needs to be investigated.

ales-erjavec added a commit to ales-erjavec/orange3 that referenced this pull request Nov 9, 2018
egg_info command used to be invoked during .travis/install_orange.sh
(as a sub-command of setuptool's sdist; since biolabgh-3345 plain distutils
sdist is used)
@ales-erjavec ales-erjavec deleted the install-help-files branch May 20, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants