[FIX] Louvain Clustering: Do not invalidate output on PCA slider change with apply disabled #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlin-policar
force-pushed
the
louvain-pca-slider-fix
branch
2 times, most recently
from
4c078ff
to
139354e
Compare
| @@ -135,6 +135,9 @@ def __init__(self): | |||
| ) # type: QWidget | |||
|
|
|||
| def _invalidate_pca_projection(self): | |||
| if not self.apply_pca: | |||
| return | |||
|
|
|||
| self.pca_projection = None | |||
There was a problem hiding this comment.
This line should be moved before the check and early return. Right? Toggling the apply_pca will only invalidate the partial results starting with the graph.
There was a problem hiding this comment.
You're right! I've fixed it now.
pavlin-policar
force-pushed
the
louvain-pca-slider-fix
branch
from
139354e
to
13823f4
Compare
Codecov Report
@@ Coverage Diff @@
## master #3339 +/- ##
==========================================
+ Coverage 82.21% 82.22% +<.01%
==========================================
Files 351 351
Lines 62301 62345 +44
==========================================
+ Hits 51219 51261 +42
- Misses 11082 11084 +2 |
lanzagar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3334
Includes