[FIX] Select Columns: Drag/drop #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3032 +/- ##
==========================================
+ Coverage 82.31% 82.37% +0.06%
==========================================
Files 335 335
Lines 57758 57791 +33
==========================================
+ Hits 47541 47604 +63
+ Misses 10217 10187 -30 |
ales-erjavec
force-pushed
the
select-columns-drag-drop
branch
from
79d6312
to
fc0c5d5
Compare
... no longer needed since biolabgh-2100 (also no longer do what they claim)
Do not call base implementation. This never worked because the base implementation stores the encoded `itemData` under the first value of `mimeTypes` result which is then promptly overwritten by us.
ales-erjavec
force-pushed
the
select-columns-drag-drop
branch
from
b2c8856
to
29b0c58
Compare
|
Drag and drop works fine now on gds data, while it stalled for more than a minute before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Drag/Drop between Select Columns list views is slow (as noticed in gh-3030)
Description of changes
Reintroduce efficient drag/drop in Select Columns
Includes