[FIX] Sorting add-ons in the alphabetical order #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3013 +/- ##
=======================================
Coverage 82.12% 82.12%
=======================================
Files 334 334
Lines 57663 57663
=======================================
Hits 47354 47354
Misses 10309 10309 |
markotoplak
previously requested changes
Apr 23, 2018
Orange/canvas/application/addons.py
Outdated
| @@ -300,6 +300,7 @@ def set_items(self, items): | |||
|
|
|||
| model.appendRow([item1, item2, item3, item4]) | |||
|
|
|||
| model.sort(1) # sorting list of add-ons in the alphabetical order | |||
There was a problem hiding this comment.
It does not work correctly. Have you tested if then the correct add-ons are also installed? If I added "pip" to the list and tried to upgrade it, it upgraded the wrong package.
There was a problem hiding this comment.
@PrimozGodec Try self.__proxy.sort(1)
There was a problem hiding this comment.
Thank you @markotoplak and @ales-erjavec. I think that now it works.
PrimozGodec
force-pushed
the
sort-addons
branch
from
79aa1fc
to
801ff2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Add-ons are in unpredictable order #3007
Description of changes
Sorting add-ons in the alphabetical order
Includes