Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Addon dialog crashes when site-packages directory does not exist #2988

Merged
merged 1 commit into from
Apr 13, 2018

Conversation

astaric
Copy link
Member

@astaric astaric commented Apr 6, 2018

PermissionError is just one of the possible errors that can be raised from a failed open attempt. When one of the other errors occurs, an error was shown (as can be seen on sentry)

Fixes #2964

PermissionError is just one of possible errors that can be raised from
failed open attempt. When one of the other erorrs occurs, an error was
shown (as can be seen on sentry)
@astaric
Copy link
Member Author

astaric commented Apr 6, 2018

@codecov-io
Copy link

Codecov Report

Merging #2988 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2988   +/-   ##
=======================================
  Coverage   81.88%   81.88%           
=======================================
  Files         329      329           
  Lines       56866    56866           
=======================================
  Hits        46563    46563           
  Misses      10303    10303

@astaric astaric changed the title addons: catch OSError in have_install_permission [FIX] addon dialog crashes when site-packages directory does not exist Apr 13, 2018
@markotoplak markotoplak changed the title [FIX] addon dialog crashes when site-packages directory does not exist [FIX] Addon dialog crashes when site-packages directory does not exist Apr 13, 2018
@markotoplak markotoplak merged commit f1d3c25 into biolab:master Apr 13, 2018
@PrimozGodec PrimozGodec added this to the 3.13 milestone Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants