[FIX] scatterplot: limit number of points displayed in tooltip #2980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astaric
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2980 +/- ##
==========================================
- Coverage 81.85% 81.85% -0.01%
==========================================
Files 329 329
Lines 56781 56784 +3
==========================================
+ Hits 46480 46482 +2
- Misses 10301 10302 +1 |
ajdapretnar
approved these changes
Mar 29, 2018
lanzagar
reviewed
Mar 29, 2018
| if len(points) > MAX_POINTS_IN_TOOLTIP: | ||
| text = "{} instances<hr/>{}<hr/>...".format( | ||
| len(points), | ||
| "<hr/>".join(point_data(point) for point in points[:5]) |
There was a problem hiding this comment.
Is the difference between the constant MAX_POINTS_IN_TOOLTIP above and the hard-coded 5 here intentional?
There was a problem hiding this comment.
yes. Displaying 20 points is ugly, but might be desired in some cases. When there are more, 5 are shown as a teaser. IMHO the tooltip looks much nicer this way :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2979
Description of changes
Display a shorter message in the tooltip when there are too many points under the mouse cursor.
Includes