[FIX] domaineditor: Give the VarTableModel a parent #2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a memory leak keeping the OWFile instance (and its loaded data) from being garbage collected.
Codecov Report
@@ Coverage Diff @@
## master #2961 +/- ##
=======================================
Coverage 81.86% 81.86%
=======================================
Files 329 329
Lines 56785 56785
=======================================
Hits 46486 46486
Misses 10299 10299 |
|
Or wait and require sip >= 4.19.9 |
|
I would include this anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
OWFile creates a uncollectable ref cycle by connecting the VarTableModel.dataChanged to a lambda capturing self (and the VarTableModel instance) in the closure.
Description of changes
Make the VarTableModel a child of the DomainEditor so it is destroyed with it.
Includes