Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Select Rows: Add annotated data output #2908

Merged
merged 8 commits into from
Feb 19, 2018

Conversation

BlazZupan
Copy link
Contributor

@BlazZupan BlazZupan commented Feb 16, 2018

Issue

Widget outputted only selected or unselected data, whereas in a number of cases one would benefit to have data with the Selected column, especially if selection would be performed on a combination or continuous meta attribute(s) and then used to test if we can predict the grouping.

Description of changes

Added an output channel (Data).

Includes
  • Code changes
  • Tests
  • Documentation

@BlazZupan BlazZupan changed the title Widget outputs annotated data. [ENH] Widget outputs annotated data. Feb 16, 2018
@ajdapretnar
Copy link
Contributor

This doesn't seem to work as it should.
No matter what I do, the second row is selected. I tried iris, titanic and housing data sets, and they all display erroneous behaviour.

screen shot 2018-02-16 at 09 20 48

@codecov-io
Copy link

codecov-io commented Feb 16, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@d9fc33a). Click here to learn what that means.
The diff coverage is 96.55%.

@@            Coverage Diff            @@
##             master    #2908   +/-   ##
=========================================
  Coverage          ?   82.15%           
=========================================
  Files             ?      329           
  Lines             ?    56347           
  Branches          ?        0           
=========================================
  Hits              ?    46292           
  Misses            ?    10055           
  Partials          ?        0

@lanzagar lanzagar changed the title [ENH] Widget outputs annotated data. [ENH] Select Rows: Add annotated data output Feb 16, 2018
@lanzagar lanzagar added this to the 3.10 milestone Feb 19, 2018
@lanzagar lanzagar merged commit 1717c4a into biolab:master Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants