Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] listfilter: Fix filter line edit completion #2896

Merged
merged 2 commits into from
Jun 1, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

Inline filter completion in the Select Columns widget does not work.

Description of changes

Make QCompleter a child of the filter line edit.

Includes
  • Code changes
  • Tests
  • Documentation

Make QCompleter a child of the filter line edit.
@codecov-io
Copy link

codecov-io commented Jan 31, 2018

Codecov Report

Merging #2896 into master will increase coverage by 0.25%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2896      +/-   ##
==========================================
+ Coverage   82.12%   82.37%   +0.25%     
==========================================
  Files         329      335       +6     
  Lines       56258    57955    +1697     
==========================================
+ Hits        46201    47742    +1541     
- Misses      10057    10213     +156

@lanzagar
Copy link
Contributor

lanzagar commented Feb 2, 2018

This results in the filter line auto-completing to the first hit and the box below shows only that one feature...
E.g. Iris with all attributes on the left; when I write "sepal" I see only one feature instead of two.

If the filter box shows the first hit, I would expect to see all matching variables in the box below, until pressing enter when the auto-complete suggestion is accepted.

@astaric astaric added this to the 3.12 milestone Mar 30, 2018
@lanzagar
Copy link
Contributor

Any suggestions on how to implement completion so as not to interfere with regular filtering tasks?
@ales-erjavec or someone else?

@lanzagar lanzagar modified the milestones: 3.12, 3.13 Apr 6, 2018
@astaric astaric modified the milestones: 3.13, 3.14 Apr 20, 2018
@astaric
Copy link
Member

astaric commented Jun 1, 2018

The completion now only works on variable attributes, so it has no effect on regular filtering.

@astaric astaric merged commit 058c76f into biolab:master Jun 1, 2018
@ales-erjavec ales-erjavec deleted the fixes/select-columns-completer branch September 12, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants