Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Feature Constructor: Make FeatureFunc picklable #2873

Merged
merged 4 commits into from
Feb 2, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

Fixes gh-2686

Description of changes
  • Make owfetureconsctructior.FeatureFunc picklable
  • Change how discrete variable's symbolic values are captured in the resulting lambda (via closure and not argument list).
  • Remove dill as a dependency
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #2873 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2873      +/-   ##
==========================================
+ Coverage   81.91%   81.93%   +0.02%     
==========================================
  Files         326      326              
  Lines       55997    55990       -7     
==========================================
+ Hits        45868    45878      +10     
+ Misses      10129    10112      -17

@lanzagar lanzagar added this to the 3.10 milestone Jan 19, 2018
@lanzagar lanzagar merged commit 8ae2017 into biolab:master Feb 2, 2018
@ales-erjavec ales-erjavec deleted the feature-constructor-serialize branch February 13, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants