New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] mssql: Catch errors due to incorrect connection params #2838

Merged

astaric merged 1 commit into biolab:master from lanzagar:mssql

Dec 22, 2017

Contributor

lanzagar commented Dec 20, 2017 •

edited

Loading

Issue

Using a string like foo\\bar for the server parameter crashed the widget (with an uncaught ValueError).

Description of changes

Includes

Code changes
Tests
Documentation


          mssql: Not all errors in connect are instances of pymssql.Error

a966fa0

lanzagar added this to the 3.9 milestone

astaric merged commit e1cc469 into biolab:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet