[FIX] Impute: Fix state serialization/restore #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanzagar
reviewed
Dec 22, 2017
Orange/widgets/data/owimpute.py
Outdated
| return type(method), None | ||
|
|
||
| methods = set(method_key(m) for m in methods) | ||
| variables = [self.varmodel[i.row()] for i in indexes] |
There was a problem hiding this comment.
This appears to be unused,
and is the same as selected_vars below.
ales-erjavec
force-pushed
the
fixes/impute-proper-state-again
branch
from
7117ef3
to
24a8df2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2830 +/- ##
==========================================
+ Coverage 82.12% 82.15% +0.03%
==========================================
Files 329 329
Lines 56258 56283 +25
==========================================
+ Hits 46201 46239 +38
+ Misses 10057 10044 -13 |
Model what the widget does not what it creates
ales-erjavec
force-pushed
the
fixes/impute-proper-state-again
branch
from
24a8df2
to
b277ebb
Compare
ales-erjavec
force-pushed
the
fixes/impute-proper-state-again
branch
from
b277ebb
to
f8591bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Change some individual variable imputer to Model based (Random forest)
Remove the Impute widget. Create a new Impute widget and connect it to File again (without connecting it to any learner):
with the same file opened in File. The Impute widget restores the variables' state as model (Random forest) but there is no Random forest input.
The problem is that Impute stores actual constructed
Imputerinstances in its settings.Description of changes
Explicitly model what the widget does and not only its (by) products.
Includes