[FIX] canvas/annotationitem: Use separate item for shadow base #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for QTBUG-65035
Codecov Report
@@ Coverage Diff @@
## master #2821 +/- ##
=========================================
- Coverage 76.2% 76.2% -0.01%
=========================================
Files 337 337
Lines 59665 59665
=========================================
- Hits 45470 45467 -3
- Misses 14195 14198 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Arrow annotations in the canvas are rendered badly on high dpi monitors. Even more so in the 'Preview' for the 'Examples' and 'Recent' dialogs. The reason for this is that
QGraphicsEffectsrender indirectly 'item -> pixmap -> effect -> draw pixmap'Description of changes
Workaround for QTBUG-65035
Use a separate item for shadow base that is stacked behind the 'true' arrow geometry item.
(the same was already done for the node items in 3be3f1a)
Includes