[FIX] Statistics.countnans/bincount: Fix NaN Counting, Consider Implicit Zeros #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ous distributions
The previous implementation didn't return zero counts for sparse matrices and treated them as NaNs. This was changed and the tests have been updated.
pavlin-policar
force-pushed
the
statistics-countnans-bincount
branch
from
d4678af
to
473f867
Compare
3 tasks
nikicc
changed the title
nikicc
changed the title
nikicc
changed the title
nikicc
changed the title
|
@pavlin-policar the tests still fail 😞 |
|
@nikicc Finally passing 😄 I don't think I can do anything about pylint though... |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The statistics module implementation of
countnansdid not support theaxisargument. Moreover, it appeared to have been computing number of NaNs incorrectly on sparse data in general.Description of changes
bincountto properly count implicit and explicit zeros, with full weight support.countnanswhich correctly counts NaNs and supports the axis keyword.dense_sparsedecorator for facilitating testing.See #2558 for discussion.
Includes