Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Silhouette Plot: another memory error #2521

Merged
merged 1 commit into from
Aug 18, 2017
Merged

[FIX] Silhouette Plot: another memory error #2521

merged 1 commit into from
Aug 18, 2017

Conversation

jerneju
Copy link
Contributor

@jerneju jerneju commented Aug 8, 2017

Issue

Related to #2336.

Silhouette Plot already catches a memory error. However that error might be caught but another error is thrown. That is

ValueError array is too big; 'arr.size * arr.dtype.itemsize' is larger than the maximum possible size.

See: https://sentry.io/biolab/orange3/issues/196744070/events/6454328021/

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Aug 8, 2017

Codecov Report

Merging #2521 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2521      +/-   ##
==========================================
+ Coverage   74.55%   74.58%   +0.02%     
==========================================
  Files         320      320              
  Lines       56209    56215       +6     
==========================================
+ Hits        41909    41927      +18     
+ Misses      14300    14288      -12

@jerneju jerneju changed the title Silhouette Plot: another memory error [FIX] Silhouette Plot: another memory error Aug 9, 2017
@thocevar thocevar self-assigned this Aug 18, 2017
@thocevar thocevar merged commit 77c5aa2 into biolab:master Aug 18, 2017
@jerneju jerneju deleted the silhouetteplot-valuememory branch August 21, 2017 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants